On Wed, Nov 2, 2011 at 5:50 PM, Ian Lance Taylor <i...@google.com> wrote:

>> #defines with arguments are not working at all. Please consider
>> following testcase:
>
> You're right: this approach doesn't work for preprocessor macros with
> arguments.  Making those work via this approach would be much much
> harder.
>
>> Please note missing "struct terminfos" define, so I understand that
>> TC[GS]ETS is unknown, but FIOCLEX should be fully defined by
>> preceeding definitions.
>
> Fortunately, the value of FIOCLEX is irrelevant.  And as you say, this
> approach can't work for TCGETS anyhow.
>
> So let's take a different approach.  This patch drops the use of TCGETS
> and TCSETS entirely.  Bootstrapped and ran Go testsuite on
> x86_64-unknown-linux-gnu.  Committed to mainline.

Ian, with your latest fixes libgo builds fine on alpha-pc-linux-gnu.

http, rpc and websocket tests that fail previously [1] now run OK, but
there are a bunch of new failures:

PASS: asn1
PASS: big
PASS: bufio
PASS: bytes
PASS: cmath
PASS: csv
../../../gcc-svn/trunk/libgo/testsuite/gotest: line 426: 26952
Segmentation fault      ./a.out -test.short -test.timeout=$timeout
"$@"
FAIL: exec
gmake[2]: *** [exec/check] Error 1
PASS: expvar
PASS: flag
PASS: fmt
PASS: gob
PASS: html
PASS: http
PASS: image
PASS: io
PASS: json
PASS: log
PASS: math
PASS: mail
PASS: mime
PASS: net
PASS: os
PASS: patch
PASS: path
PASS: rand
PASS: reflect
PASS: regexp
PASS: rpc
PASS: runtime
PASS: scanner
PASS: smtp
PASS: sort
PASS: strconv
PASS: strings
PASS: sync
PASS: syslog
PASS: tabwriter
PASS: template
PASS: time
PASS: unicode
PASS: url
PASS: utf16
PASS: utf8
PASS: websocket
PASS: xml
../../../gcc-svn/trunk/libgo/testsuite/gotest: line 426:  5164
Segmentation fault      ./a.out -test.short -test.timeout=$timeout
"$@"
FAIL: archive/tar
gmake[2]: *** [archive/tar/check] Error 1
panic: runtime error: invalid memory address or nil pointer dereference
../../../gcc-svn/trunk/libgo/testsuite/gotest: line 426:  5316 Aborted
                ./a.out -test.short -test.timeout=$timeout "$@"
FAIL: archive/zip
gmake[2]: *** [archive/zip/check] Error 1
PASS: compress/bzip2
PASS: compress/flate
PASS: compress/gzip
PASS: compress/lzw
PASS: compress/zlib
PASS: container/heap
PASS: container/list
PASS: container/ring
PASS: crypto/aes
PASS: crypto/bcrypt
PASS: crypto/blowfish
PASS: crypto/cast5
PASS: crypto/cipher
PASS: crypto/des
PASS: crypto/dsa
PASS: crypto/ecdsa
PASS: crypto/elliptic
PASS: crypto/hmac
PASS: crypto/md4
PASS: crypto/md5
PASS: crypto/ocsp
PASS: crypto/openpgp
PASS: crypto/rand
PASS: crypto/rc4
PASS: crypto/ripemd160
PASS: crypto/rsa
PASS: crypto/sha1
PASS: crypto/sha256
PASS: crypto/sha512
PASS: crypto/subtle
PASS: crypto/tls
PASS: crypto/twofish
PASS: crypto/x509
PASS: crypto/xtea
PASS: crypto/openpgp/armor
PASS: crypto/openpgp/elgamal
PASS: crypto/openpgp/packet
PASS: crypto/openpgp/s2k
PASS: debug/dwarf
PASS: debug/elf
PASS: debug/macho
PASS: debug/pe
PASS: encoding/ascii85
PASS: encoding/base32
PASS: encoding/base64
PASS: encoding/binary
PASS: encoding/git85
PASS: encoding/hex
PASS: encoding/pem
PASS: exp/ebnf
PASS: exp/norm
PASS: exp/spdy
PASS: exp/sql
PASS: exp/ssh
PASS: exp/terminal
PASS: exp/template/html
PASS: go/ast
PASS: go/parser
PASS: go/printer
PASS: go/scanner
PASS: go/token
PASS: hash/adler32
PASS: hash/crc32
PASS: hash/crc64
PASS: hash/fnv
PASS: http/cgi
PASS: http/fcgi
PASS: image/draw
PASS: image/jpeg
PASS: image/png
PASS: image/tiff
PASS: image/ycbcr
PASS: index/suffixarray
PASS: io/ioutil
PASS: mime/multipart
PASS: net/textproto
PASS: old/netchan
PASS: old/regexp
PASS: old/template
PASS: os/user
PASS: os/signal
PASS: path/filepath
PASS: regexp/syntax
PASS: rpc/jsonrpc
PASS: sync/atomic
PASS: template/parse
PASS: testing/quick
PASS: testing/script

[1] http://gcc.gnu.org/ml/gcc-patches/2011-07/msg00457.html

Uros.

Reply via email to