On 9/16/18 5:28 AM, Rainer Orth wrote: > Currently, the libgcc-unwind.map file generated for use with Solaris ld > > http://gcc.gnu.org/ml/gcc-patches/2014-01/msg01088.html > > uses the v1 linker map file syntax because both that's supported > everywhere. However, with ld -z guidance, newer versions of ld warn > about this: > > ld: guidance: version 2 mapfile syntax recommended: ./libgcc-unwind.map > > Since it is easy to detect if ld supports v2 map syntax (introduced in > Solaris 11 and later backported to some Solaris 10 patches) and the > mapfile is generated at build time, the following patch performs this > check and generates a v2 mapfile if ld supports it. > > While testing the patch, I found that the arg to AC_TRY_COMMAND needed > quoting to avoid the embedded commas in -Wl,-M,... ended the command. > Shouldn't the other uses of AC_TRY_COMMAND receive the same quoting for > safety and consistency? > > Bootstrapped on i386-pc-solaris2.10 (with older v1-only ld) and > i386-pc-solaris2.11 without regressions. > > Ok for mainline? OK with a suitable ChangeLog.
Jeff
