On Mon, Sep 10, 2018 at 12:58:19PM +0200, Ilya Leoshkevich wrote: > > Am 06.09.2018 um 20:11 schrieb Jeff Law <l...@redhat.com>: > > This is (of course) much easier to do when the target block has no insns > > other than the conditional branch. So perhaps only do this when the > > target block has just the conditional? > Sounds reasonable, I implemented this in the new patch. The only thing > is that combine leaves (note NOTE_INSN_DELETED) around, so I needed to > also account for those. I used side_effects_p for that.
Combine cannot delete insns because various things in combine refer to insns by uid. It could of course delete insns after it is done, hrm, I'll have a look at that. Either way, you'll also have lots of other notes still hanging around (esp. with debug info). Segher
