On 8/29/18 4:30 AM, Iain Sandoe wrote:
> Hi,
>
> I have noticed, for some configuration cases, that the ms-sysv tests fail
> with “can’t build generator”.
>
> The setting of HOSTCXX in gcc/testsuite/gcc/site.exp is dependent on the top
> level configuration;
> for example, configuring with —target,host,build = x86_64-linux-gnu or
> CXX=/usr/bin/g++ sets the
> site.exp HOSTCXX to the discovered bootstrap compiler
>
> Whereas, configuring with a plain …/configure .. sets HOSTCXX to
> prev-gcc/xg++.
>
> In the latter case, the “host” compiler can respond to TEST_ALWAYS_FLAGS, in
> the former cases
> it cannot necessarily (unless one is bootstrapping with gcc-9).
>
> The patch below removes TEST_ALWAYS_FLAGS from the generator build - and the
> tests pass for
> me on x86_64-linux and x86_64-darwin with various configuration lines.
>
> If that doesn’t cover enough cases, and it’s really necessary that the
> generator is built with
> TEST_ALWAYS_FLAGS, then support for them in HOSTCXX needs to be checked
> (there is already a
> check for the host compiler support for c++11).
>
> OK for trunk?
> thanks
> Iain
>
> gcc/testsuite/
>
> * gcc.target/x86_64/abi/ms-sysv/ms-sysv.exp (runtest_ms_sysv): Don’t
> assume that the HOSTCXX supports TEST_ALWAYS_FLAGS.
OK.
jeff
