On 8/24/18 3:24 PM, Bernd Edlinger wrote: > Hi, > > I noticed that the latest patches to make STRING_CST > semantics for literals and for initializers consistent > also fixes PR 86711 and PR 86714 (but not PR 87053). > > The code change in the string_constant does not change > any test case, the new test cases are already fixed > once we have the unified STRING_CST semantics. > Thus https://gcc.gnu.org/ml/gcc-patches/2018-08/msg01569.html > would be the pre-condition for this patch. > > If the pre-condition patch is applied then my earlier patch > to fix PR 86711/86714 is no longer necessary. > Likely neither Martin's patch (at least that part about > PR 86711/86714). > > > Bootstrapped and reg-tested on x86_64-pc-linux-gnu. > Is it OK for trunk? > > > Thanks > Bernd. > > > patch-stringconst.diff > > gcc: > 2018-08-24 Bernd Edlinger <bernd.edlin...@hotmail.de> > > * expr.c (string_constant): Adjust function comment. > Remove bogus check for zero termination. > > testsuite: > 2018-08-24 Bernd Edlinger <bernd.edlin...@hotmail.de> > > PR middle-end/86711 > PR middle-end/86714 > * gcc.c-torture/execute/pr86711.c: New test. > * gcc.c-torture/execute/pr86714.c: New test. So I applied the expr.c part of this patch. We've already got these tests in the testsuite.
jeff
