On 2018/9/11 1:22 AM, Cesar Philippidis wrote:
On 09/10/2018 08:04 AM, Chung-Lin Tang wrote:
GOACC_2.0 {
Index: libgomp/oacc-mem.c
===================================================================
--- libgomp/oacc-mem.c (revision 264192)
+++ libgomp/oacc-mem.c (working copy)
@@ -153,8 +153,9 @@ acc_free (void *d)
gomp_fatal ("error in freeing device memory in %s", __FUNCTION__);
}
-void
-acc_memcpy_to_device (void *d, void *h, size_t s)
+static void
+memcpy_tofrom_device (bool from, void *d, void *h, size_t s, int async,
+ const char *libfnname)
This showed up oddly in the diff, but memcpy_tofrom_device is a new
internal function that's not part of the public API. It's nice that you
were able to merge the to/from functions together. I think this is safe
in terms of backwards compatibility.
Yes, this patch only adds new API functions, though some internal refactoring
was done.
No compatibility was compromised, if that wasn't apparent.
While I can't approve this patch, it seems reasonable to me. I like how
you cleaned up things from OG8 (e.g., replacing return (n ? 1 : 0) with
return n != NULL'). Are there any other OG8 async patches in your queue?
Yeah, there are more, this is just a smaller, independent part of the whole set
of changes,
as you also probably know.
Thanks,
Chung-Lin
