On 09/05/2018 03:29 PM, Joey Ye wrote: > This is a fix to an obvious issue in gcov.exp, where proc verify-intermediate > returns without closing the open file. > > This can be a possible fix to PR85871. gcov-8.C diffs to other gcov testcases > that it invokes verify-intermediate. Not closing an open file may result in > random failure quietly. > > It is only a possible fix as I failed to reproduce the PR85871 random failure > in my local machine despite continuous testing of multiple days. So I cannot > verify if this patch fixes the regression either. > > To verify, https://gcc.gnu.org/ml/gcc-testresults/ need to be watched whether > gcov-8 regression will disappear completely one month after this patch > committed to trunk. > > Tested with make check with no new regressions. > > OK to trunk? > > testsuite/ChangeLog: > 2018-09-05 Joey Ye <joey...@arm.com> > > * lib/gcov.exp (verify-intermediate): Add missing close. >
Hi. Thanks for the fix, it's obvious. Please install the patch. Note that gcov-8.C is built multiple times with different -std=* options: PASS: g++.dg/gcov/gcov-8.C -std=gnu++98 (test for excess errors) PASS: g++.dg/gcov/gcov-8.C -std=gnu++98 execution test PASS: g++.dg/gcov/gcov-8.C -std=gnu++98 gcov PASS: g++.dg/gcov/gcov-8.C -std=gnu++11 (test for excess errors) PASS: g++.dg/gcov/gcov-8.C -std=gnu++11 execution test PASS: g++.dg/gcov/gcov-8.C -std=gnu++11 gcov PASS: g++.dg/gcov/gcov-8.C -std=gnu++14 (test for excess errors) PASS: g++.dg/gcov/gcov-8.C -std=gnu++14 execution test PASS: g++.dg/gcov/gcov-8.C -std=gnu++14 gcov That can cause the collisions seen in the PR. Martin
