On Wed, 5 Sep 2018 at 20:57, Janne Blomqvist <blomqvist.ja...@gmail.com> wrote: > > On Wed, Sep 5, 2018 at 5:58 PM Bernhard Reutner-Fischer > <rep.dot....@gmail.com> wrote:
>> Bootstrapped and regtested on x86_64-foo-linux. >> >> I'd appreciate if someone could double check for regressions on other >> setups. Git branch: >> https://gcc.gnu.org/git/?p=gcc.git;a=log;h=refs/heads/aldot/fortran-fe-stringpool >> >> Ok for trunk? > > > Hi, > > this is quite an impressive patch set. I have looked through all the patches, > and on the surface they all look ok. Thanks alot for your appreciation! > > Unfortunately I don't have any exotic target to test on either, so I think > you just have to commit it and check for regression reports. Though I don't > see this set doing anything which would work differently on other targets, > but you never know.. > > I'd say wait a few days in case anybody else wants to comment on it, then > commit it to trunk. Upon further testing i encountered a regression in module writing, manifesting itself in a failure to compile ieee_8.f90 (and only this). f951: Fatal Error: Reading module ‘foo’ at line 4310 column 25: Expected string where we write the following garbage: 366 ''''''''''''''''res'BLE IN UNKNOWN-PROC UNKNOWN UNKNOWN 0 0 End of last year when i wrote these patches i diffed each and every module in my regtests and all these were identical, so it must be some recent "regression" in that area. Sorry for that, I'll have another look during the weekend. thanks,
