On Wed, 2018-09-05 at 09:39 -0400, David Malcolm wrote: > On Wed, 2018-09-05 at 12:49 +0100, a...@codesourcery.com wrote: > > The plain "sorry" diagnostic only gives the "current" location, > > which > > is > > typically the last line of the function or translation unit by time > > we get to > > the back end. > > > > GCN uses "sorry" to report unsupported language features, such as > > static > > constructors, so it's useful to have a "sorry_at" variant. > > > > This patch implements "sorry_at" according to the pattern of the > > other "at" > > variants. > > > > 2018-09-05 Andrew Stubbs <a...@codesourcery.com> > > > > gcc/ > > * diagnostic-core.h (sorry_at): New prototype. > > * diagnostic.c (sorry_at): New function. > > --- > > gcc/diagnostic-core.h | 1 + > > gcc/diagnostic.c | 11 +++++++++++ > > 2 files changed, 12 insertions(+) > > OK, thanks.
Actually, not quite: "sorry" has changed slightly on trunk since you copied it. Please add the: auto_diagnostic_group d; line to the top of the function. OK with that change.