On Tue, 4 Sep 2018 at 18:43, Andrew Benson <aben...@carnegiescience.edu> wrote: > > As suggested by Janus, PR87103 is easily fixed by the attached patch which > increases GFC_MAX_SYMBOL_LEN to 76 (sufficient to hold the maximum allowed F08 > symbol length of 63, plus a null terminator, plus the "__tmp_class_" prefix).
This is so much wrong. Note that this will be fixed properly by the changes contained in the https://gcc.gnu.org/git/?p=gcc.git;a=shortlog;h=refs/heads/aldot/fortran-fe-stringpool branch. There we keep the GFC_MAX_SYMBOL_LEN at 63 proper but use an internal buffer double that size which in turn is sufficient to hold all compiler-generated identifiers. See gfc_get_string() even in current TOT. Maybe we should bite the bullet and start to merge the stringpool changes now instead of this hack? thanks and cheers,
