On Tue, Aug 21, 2018 at 03:14:29PM +0200, Martin Liška wrote: > On 08/18/2018 12:24 AM, Segher Boessenkool wrote: > > Removing Init is *wrong* as far as I see; it changes things, anyway. > > Could you not have done this as a separate patch? > > It's already in, but it should be fine. Note that I added check into > opt-functions.awk where I can't use Var with Deprecated or Ignore attribute. > Thus removal of Init should be fine. Or am I wrong?
rs6000 had Target Undocumented Mask(DIRECT_MOVE) Var(rs6000_isa_flags) Ignore Warn(%qs is deprecated) and you removed the Ignore. Putting it back complains about Ignore+Warn (which is explicitly allowed by the documentation!), and about Ignore+Var (which we need here, and is no problem ever as far as I see). Just putting Ignore back and disabling those two warnings seems to work fine. But I don't know what your patch really tried to do, so could you look at this please? [ This is PR87164, which you already assigned to yourself, thanks :-) ] Segher
