Hi Rasmus,

> On 27 Jun 2018, at 16:27, Rasmus Villemoes <r...@rasmusvillemoes.dk> wrote:
>       * inclhack.def (AAB_vxworks_regs_vxtypes): Guard include of
>       types/vxTypesOld.h by #ifndef _ASMLANGUAGE.
>       * fixincl.x: Regenerate.
> ---
> fixincludes/inclhack.def | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/fixincludes/inclhack.def b/fixincludes/inclhack.def
> index c1f5a13eda4..bac0079b69f 100644
> --- a/fixincludes/inclhack.def
> +++ b/fixincludes/inclhack.def
> @@ -426,7 +426,9 @@ fix = {
>     replace     = <<- _EndOfHeader_
>       #ifndef _REGS_H
>       #define _REGS_H
> +     #ifndef _ASMLANGUAGE
>       #include <types/vxTypesOld.h>
> +     #endif
>       #include_next <arch/../regs.h>
>       #endif
>       _EndOfHeader_;

This will really look puzzling to a reader and would
at least deserve a comment. 

How do we not get in assembly the problems we'd get in C
when not including vxTypesOld ?

Olivier



Reply via email to