This doesn't seem obvious to me, since it is removing information from the interface of the function. But it is OK.
On Tue, Aug 21, 2018 at 10:20 PM, Paolo Carlini <paolo.carl...@oracle.com> wrote: > Hi, > > over the last couple of weeks I started auditing the front-end about > problematic uses of permerror (say, the user passes -fpermissive and after > the warning we immediately return error_mark_node anyway: the assembly most > likely will not make sense) and noticed that we don't use anywhere the > return value of check_static_variable_definition (luckily, because we are > returning 1 both for error and permerror), thus the below, which just > changes the return type to void and consistently adjusts the body. I mean to > commit it as obvious after testing finishes... > > Thanks, Paolo. > > //////////////////////////// >
