On 08/13/2018 09:21 AM, Julian Brown wrote:
> diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-gwv-2.c
> b/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-gwv-2.c
> new file mode 100644
> index 0000000..2fa708a
> --- /dev/null
> +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-gwv-2.c
> @@ -0,0 +1,106 @@
> +/* { dg-xfail-run-if "gangprivate failure" { openacc_nvidia_accel_selected }
> { "-O0" } { "" } } */
As a quick comment, I like the approach that you've taken with this
patch, but the og8 patch only applies the gangprivate attribute in the
c/c++ FE. I'd have to review the notes, but I seem to recall that
excluding that clause in fortran was deliberate. Chung-Lin, do you
recall the rationale behind that?
With that aside, is the above xfail still necessary? It seems to xpass
for me on nvptx. However, I see this regression on the host:
FAIL: libgomp.oacc-c/../libgomp.oacc-c-c++-common/loop-gwv-2.c
-DACC_DEVICE_TYPE_host=1 -DACC_MEM_SHARED=1 -O2 execution test
There could be other regressions, but I only tested the new tests
introduced by the patch so far.
Cesar
