On Jul 28 2018, "slyfox.inbox.ru via gcc-patches" <gcc-patches@gcc.gnu.org> 
wrote:

> diff --git a/libitm/config/sh/sjlj.S b/libitm/config/sh/sjlj.S
> index 043f36749be..80a810d8360 100644
> --- a/libitm/config/sh/sjlj.S
> +++ b/libitm/config/sh/sjlj.S
> @@ -53,7 +53,7 @@ _ITM_beginTransaction:
>  #else
>       cfi_def_cfa_offset (4*10)
>  #endif
> -#if defined HAVE_ATTRIBUTE_VISIBILITY || !defined __PIC__
> +#if defined HAVE_ATTRIBUTE_VISIBILITY && !defined __PIC__
>       mov.l   .Lbegin, r1
>       jsr     @r1
>        mov    r15, r5
> @@ -78,7 +78,7 @@ _ITM_beginTransaction:
>  
>       .align  2
>  .Lbegin:
> -#if defined HAVE_ATTRIBUTE_VISIBILITY || !defined __PIC__
> +#if defined HAVE_ATTRIBUTE_VISIBILITY && !defined __PIC__
>       .long   GTM_begin_transaction
>  #else
>       .long   GTM_begin_transaction@PCREL-(.Lbegin0-.)

If those references to hidden symbols cannot be resolved by the linker
then the use of HAVE_ATTRIBUTE_VISIBILITY is pointless.

Andreas.

-- 
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Reply via email to