> On Jul 20, 2018, at 9:59 AM, Jakub Jelinek <ja...@redhat.com> wrote: > > On Fri, Jul 20, 2018 at 09:53:24AM -0500, Qing Zhao wrote: >> +2018-07-20 Qing Zhao <qing.z...@oracle.com> >> + >> + * builtins.c (expand_builtin_memcmp): Delete the last parameter for >> + call to inline_expand_builtin_string_cmp. >> + (expand_builtin_strcmp): Likewise. >> + (expand_builtin_strncmp): Likewise. >> + (inline_string_cmp): Delete the last parameter, change char_type_node >> + to unsigned_char_type_node for strcmp/strncmp, add conversions to the >> + two operands. >> + (inline_expand_builtin_string_cmp): Delete the last parameter, give >> up >> + the inlining expansion on target where the type of the call has same >> or >> + narrower presicion than unsigned char. > > s/presicion/precision/ > > Also in the patch, where there is another typo, s/of/or/.
Okay. > > Ok for trunk with that fixed. thanks a lot for the review. Qing > > Jakub