On Fri, Jul 13, 2018 at 12:24:02PM -0400, Nathan Sidwell wrote: > On 07/13/2018 09:49 AM, Jakub Jelinek wrote: > > Hi! > > > > I'd like to ping the following C++ patches: > > > > - PR c++/85515 > > make range for temporaries unspellable during parsing and only > > turn them into spellable for debug info purposes > > http://gcc.gnu.org/ml/gcc-patches/2018-07/msg00086.html > > > How hard would it be to add the 6 special identifiers to the C++ global > table via initialize_predefined_identifiers (decl.c) and then use them > directly in the for range machinery? repeated get_identifier > ("string-const") just smells bad.
Probably not too hard, but we have hundreds of other get_identifier ("string-const") calls in the middle-end, C++ FE, other FEs. Are those 6 more important than say "abi_tag", "gnu", "begin", "end", "get", "tuple_size", "tuple_element", and many others? Is it worth caching those? Jakub