On 21/06/18 21:39 +0100, Jonathan Wakely wrote:
Apparently we never updated the x86_64-linux-gnu baseline for gcc-8 (so now that I'm trying to add a new symbol version on trunk, I'm seeing errors for the get_entropy symbol added in the previous symbol version).
The same change is needed for ppc64 on trunk and gcc-8-branch, so I'm committing this. The following targets still need their baseline_symbols files updated on trunk and gcc-8-branch: find config/abi/post/ -name baseline_symbols.txt | xargs fgrep -L 3.4.25 config/abi/post/mips64-linux-gnu/32/baseline_symbols.txt config/abi/post/mips64-linux-gnu/64/baseline_symbols.txt config/abi/post/mips64-linux-gnu/baseline_symbols.txt config/abi/post/mips-linux-gnu/baseline_symbols.txt config/abi/post/sparc-linux-gnu/baseline_symbols.txt config/abi/post/s390-linux-gnu/baseline_symbols.txt config/abi/post/s390x-linux-gnu/32/baseline_symbols.txt config/abi/post/s390x-linux-gnu/baseline_symbols.txt Target maintainers, this can be done by "make new-abi-baseline" in the $build/$target/libstdc++-v3/testsuite directory. The "make check-abi" target will already be failing on trunk (as we've added new symbols there) and we plan to add new libstdc++ symbols to gcc-8-branch in the near future, so the baselines should be updated on the branch too. Thanks in advance.
commit 36086e7d1340e2b9c8b63e8b6e6b0405666f6a0b Author: Jonathan Wakely <jwak...@redhat.com> Date: Mon Jun 25 21:18:59 2018 +0100 Update powerpc64-linux-gnu/baseline_symbols.txt PR libstdc++/81092 * config/abi/post/powerpc64-linux-gnu/baseline_symbols.txt: Update. diff --git a/libstdc++-v3/config/abi/post/powerpc64-linux-gnu/baseline_symbols.txt b/libstdc++-v3/config/abi/post/powerpc64-linux-gnu/baseline_symbols.txt index 50734641c5b..9d070517326 100644 --- a/libstdc++-v3/config/abi/post/powerpc64-linux-gnu/baseline_symbols.txt +++ b/libstdc++-v3/config/abi/post/powerpc64-linux-gnu/baseline_symbols.txt @@ -444,6 +444,7 @@ FUNC:_ZNKSt13basic_fstreamIwSt11char_traitsIwEE7is_openEv@GLIBCXX_3.4 FUNC:_ZNKSt13basic_istreamIwSt11char_traitsIwEE6gcountEv@@GLIBCXX_3.4 FUNC:_ZNKSt13basic_istreamIwSt11char_traitsIwEE6sentrycvbEv@@GLIBCXX_3.4 FUNC:_ZNKSt13basic_ostreamIwSt11char_traitsIwEE6sentrycvbEv@@GLIBCXX_3.4 +FUNC:_ZNKSt13random_device13_M_getentropyEv@@GLIBCXX_3.4.25 FUNC:_ZNKSt13runtime_error4whatEv@@GLIBCXX_3.4 FUNC:_ZNKSt14basic_ifstreamIcSt11char_traitsIcEE5rdbufEv@@GLIBCXX_3.4 FUNC:_ZNKSt14basic_ifstreamIcSt11char_traitsIcEE7is_openEv@@GLIBCXX_3.4.5 @@ -4237,6 +4238,8 @@ OBJECT:0:GLIBCXX_3.4.20 OBJECT:0:GLIBCXX_3.4.21 OBJECT:0:GLIBCXX_3.4.22 OBJECT:0:GLIBCXX_3.4.23 +OBJECT:0:GLIBCXX_3.4.24 +OBJECT:0:GLIBCXX_3.4.25 OBJECT:0:GLIBCXX_3.4.3 OBJECT:0:GLIBCXX_3.4.4 OBJECT:0:GLIBCXX_3.4.5