Hi! On Fri, Jun 22, 2018 at 08:21:35AM -0700, Carl Love wrote: > GCC Maintainers: > > The following patch adds tests for the vec_extract builtin. I also > adjusts the second argument on the existing tests so they match the > ABI, specifically an integer not a const integer.
Does that make a difference anywhere? It shouldn't as far as I know. > --- /dev/null > +++ b/gcc/testsuite/gcc.target/powerpc/p9-extract-4.c > @@ -0,0 +1,30 @@ > +/* { dg-do compile { target { powerpc64*-*-* && lp64 } } } */ powerpc*-*-* && lp64 > +/* This file tests the extraction of 64-bit values. The direct move is > + prefered for the 64-bit extract as it is either lower latency or the same > + latency as the extract instruction depending on the Endianess of the > system. > + Furthermore, there can be up to four move instructions in flight at a time > + versus only two extract intructions at a time. */ Please say this is for Power9? It won't stay true forever. Okay for trunk with those trivial changes. Thanks! Segher