[ was: Re: [MAINTAINERS, committed] Remove redundant write-after-approval
entries ]

On Tue, Jun 12, 2018 at 10:26:31AM +0200, Martin Liška wrote:
> Hi.
> 
> Thanks for the script, it also found me in Write After Approval section.
> Thus I'll install following patch.
> 
> Tom what about installing the script into contrib?

I've renamed the script to contrib/maintainers-verify.sh.

Also I've added a regression test that runs it:
...
Running src/gcc/testsuite/gcc.src/maintainers.exp ...
PASS: maintainers-verify.sh
...

When failing (by reverting your patch on MAINTAINERS), it shows in gcc.log:
...
Running src/gcc/testsuite/gcc.src/maintainers.exp ...
Redundant in write approval: Martin Liska
FAIL: maintainers-verify.sh
...

OK for trunk?

Thanks,
- Tom

Reply via email to