On Tue, Jun 05, 2018 at 06:53:43AM -0700, Cesar Philippidis wrote:
> OpenACC declare is implemented somewhat special in the Fortran FE in
> that it preforms its own data clause error handling. As PR85701
> demonstrated, one situation that lacked test coverage was passing in
> function and subroutine identifiers as data clause arguments to acc
> declare. This patch rectifies that issue by checking for the function
> and subroutine symbol attribute and issuing an error when it detects
> such a symbol. The Fortran FE also has attributes for other types of
> functions, but gfc_match_omp_variable_list already handle those.
> However, as GCC gains support for derived-type objects, this may have to
> be revisited.
>
> I tested this patch on x86_64 with nvptx offloading. Is it OK for trunk
> and the stable branches?
>
> Thanks,
> Cesar
> 2018-06-05 Cesar Philippidis <ce...@codesourcery.com>
>
> PR fortran/85701
>
> gcc/fortran/
> * openmp.c (gfc_resolve_oacc_declare): Error on functions and
> subroutine data clause arguments.
>
> gcc/testsuite/
> * gfortran.dg/goacc/pr85701.f90: New test.
Ok, thanks.
Jakub
