Hi Carl, On Tue, May 29, 2018 at 08:37:01AM -0700, Carl Love wrote: > * gcc.target/powerpc/builtins-3.c: Add tests > test_sll_vuill_vuill_vuc,
Stray tab. > +/* { dg-final { scan-assembler-times "vupklpx" 1 { target le } } } */ > +/* { dg-final { scan-assembler-times "vupklpx" 1 { target be } } } */ > +/* { dg-final { scan-assembler-times "vupkhpx" 1 { target le } } } */ > +/* { dg-final { scan-assembler-times "vupkhpx" 1 { target be } } } */ That is fine of course, but looks a bit silly ;-) Merge them? > +/* { dg-final { scan-assembler-times "xxlor" 11 { target { be && ilp32 } } } > } */ > +/* { dg-final { scan-assembler-times "xxlor" 7 { target { be && lp64 } } } > } */ > +/* { dg-final { scan-assembler-times "xxlor" 7 { target le } } } */ You can do this with just "11 { target ilp32 }" and "7 { target lp64 }", if that makes sense for the test. > +/* { dg-final { scan-assembler-times {\mrldic\M} 0 { target { be && ilp32 } > } } } */ > +/* { dg-final { scan-assembler-times {\mrldic\M} 64 { target { be && lp64 } > } } } */ > +/* { dg-final { scan-assembler-times {\mrldic\M} 64 { target le } } } */ Similar. Looks great otherwise. Okay for trunk. Thanks! Segher