On Tue, May 22, 2018 at 10:37:30AM -0500, Wilco Dijkstra wrote:
> James Greenhalgh wrote:
>
> > +/* Determine whether a frame chain needs to be generated. */
> > +static bool
> > +aarch64_needs_frame_chain (void)
> > +{
> > + /* Force a frame chain for EH returns so the return address is at FP+8.
> > */
> > + if (frame_pointer_needed || crtl->calls_eh_return)
> > + return true;
>
> > To match the original logic, I think this needs to not return true, but set
> > some temporary to true which may be overwritten by...
>
> It's only overwritten if false, once true it cannot ever become false.
Doh, of course.
OK for trunk.
Thanks,
James
