On 04/19/2018 03:43 AM, Andrew Sadek wrote:
On Wed, Apr 18, 2018 at 6:57 PM, Michael Eager <ea...@eagercon.com> wrote:
Hi Andrew --
Check indents in the following files:
(Make sure that your tabs are set at 8 chars.)
--- gcc/config/microblaze/microblaze.c
--- gcc/config/microblaze/microblaze.md
I have re-run check_GNU_Style.sh and no are issues are found now.
I corrected a large number of indent problems in microblaze.c.
Just a couple coding notes:
microblaze.c:
@@ -858,6 +879,16 @@ microblaze_classify_address (struct microblaze_add
+ && strict == 2)
Include comment in function header describing meaning of strict == 2.
Done
@@ -1022,7 +1065,7 @@ microblaze_legitimize_address (rtx x, rtx oldx ATT
else if (flag_pic == 2 && !TARGET_PIC_DATA_TEXT_REL)
{
...
}
else if (flag_pic == 2 && TARGET_PIC_DATA_TEXT_REL)
{
...
}
It's better to factor this into
else if (flag_pic == 2)
{
if (TARGET_PIC_DATA_TEXT_REL)
{
...
}
else
{
...
}
}
Done
This code pattern appears twice in microblaze_legitimize_address.
I corrected the second one.
The code in the second occurrence can be refactored to move
if (reload_in_progress)
df_set_regs_ever_live (PIC_OFFSET_TABLE_REGNUM, true);
out of the if(TARGET_PIC_DATA_TEXT_REL) brackets. (Done.)
Please send me an updated ChangeLog, including testsuite.
--
Michael Eager ea...@eagerm.com
1960 Park Blvd., Palo Alto, CA 94306
