On Tue, Apr 10, 2018 at 11:14 AM, Uros Bizjak <ubiz...@gmail.com> wrote:
> On Tue, Apr 10, 2018 at 10:45 AM, Richard Earnshaw (lists)
> <richard.earns...@arm.com> wrote:
>
>>>> Alpha should be fixed -- the docs clearly state that the operand is "the
>>>> memory reference in the stack that needs to be probed". Just passing in
>>>> the offset seems wrong.
>>>
>>> This pattern has to be renamed to not clash with the standard pattern name.
>>>
>>> I'm testing the attached patch.
>>>
>>
>> Ugh! Two different APIs, one called gen_stack_probe and one
>> gen_probe_stack? That has to be a recipe for disaster!
>
> It is just an unforunatelly named helper expander. Maybe
> "stack_probe_internal" is indeed a bettern name.
Now committed with the above change and following ChangeLog entry:
2018-04-11 Uros Bizjak <ubiz...@gmail.com>
* config/alpha/alpha.md (stack_probe_internal): Rename
from "probe_stack". Update all callers.
Bootstrapped and regression tested on alphaev68-linux-gnu.
Uros.
