> On Apr 4, 2018, at 3:53 AM, Jakub Jelinek <ja...@redhat.com> wrote: > > On Sun, Apr 01, 2018 at 08:24:32PM -0500, Bill Schmidt wrote: >> I also updated the gcc.target/powerpc/powerpc.exp file to allow C++ >> tests to be placed in that directory (with a *.C suffix). > > I think this is wrong. > Historically, we've been putting target C++ tests into g++.dg/*/*.C > with appropriate target guards, the gcc.target/ tests are compiled with the > gcc driver rather than g++, so in your case it just happens to work because > it is a compile time test only (and one that doesn't use any STL headers), > e.g. dg-do run test would fail miserably. > > If we (for GCC9?) want to create a spot for target C++ tests, we should > just add g++.target/<cpu>/ directories and add all the needed infrastructure > for those. > > Can you please revert the powerpc.exp change and move the test to > g++.dg/ext/ ? Thanks.
Sure, I can -- I just want to point out that there is precedent here. I noticed that gcc.target/s390/s390.exp allows .C suffixes and there is one such (compile-only) test in that directory, so I assumed the framework was okay for this. Thanks, Bill > > Jakub >
