On Wed, Mar 14, 2018 at 8:57 PM, Jason Merrill <ja...@redhat.com> wrote: > Ping > > On Fri, Mar 2, 2018 at 1:23 PM, Jason Merrill <ja...@redhat.com> wrote: >> As I mentioned in the PR, the problem here is that we're replacing a >> constructor with a dispatcher function which doesn't look much like a >> constructor. This patch adjusts make_dispatcher_decl to make it look >> more like the functions it dispatches to, but other things are certain >> to break for similar reasons down the road. A proper solution should >> be more transparent, like thunks. >> >> Tested x86_64-pc-linux-gnu. Does this seem worth applying to fix the >> regression?
The patch looks reasonable to me, you probably know best whether the cp/ parts are risky or not ;) So - OK from my POV. And yes, thunks may be a better representation for the dispatcher. Richard.
