Hi Carl,

On Wed, Mar 14, 2018 at 08:32:54AM -0700, Carl Love wrote:
> 2018-03-13  Carl Love  <c...@us.ibm.com>
> 
>       PR 84422 - ICE on various builtin test functions when compiled with
>       -mcpu=power7.

This should be _exactly_

        PR target/84422

(one such line per PR, and no blank line after it) so that bugzilla
will automagically pick it up.

>       * config/rs6000/rs6000-builtin.def: Change expansion for
>       VMULE[SW|UW] to BU_P8V_AV_2.
>       * config/rs6000/rs6000.c: Change
>       ALTIVEC_BUILTIN_VMULE[SW|UW] to P8V_BUILTIN_VMULE[SW|UW].
>       Change ALTIVEC_BUILTIN_VMULO[SW|UW] to P8V_BUILTIN_VMULO[SW|UW].
>       * config/rs6000/rs6000-c.c: Change
>       ALTIVEC_BUILTIN_VMULE[SW|UW] to P8V_BUILTIN_VMULE[SW|UW].
>       Change ALTIVEC_BUILTIN_VMULO[SW|UW] to P8V_BUILTIN_VMULO[SW|UW].

If you don't use the literal names it becomes very hard to grep for.

The patch itself looks fine.  Okay for trunk.  Thanks!


Segher

Reply via email to