Christophe Lyon <christophe.l...@linaro.org> writes: > On 8 February 2018 at 14:54, Richard Sandiford > <richard.sandif...@linaro.org> wrote: >> Index: gcc/testsuite/gcc.target/aarch64/sve/mul_highpart_1_run.c >> =================================================================== >> --- /dev/null 2018-02-08 11:17:10.862716283 +0000 >> +++ gcc/testsuite/gcc.target/aarch64/sve/mul_highpart_1_run.c 2018-02-08 >> 13:51:56.253511883 +0000 >> @@ -0,0 +1,29 @@ >> +/* { dg-do run } */ > You forgot to include an effective target to prevent trying to run on > non-SVE capable HW.
Oops, sorry about that. I had the fix in the tree I use for non-SVE testing but forgot to update the commit tree. Applied as below. > I suppose check_effective_target_aarch64_sve_hw would work, but I 'm > not sure it's sufficient to prevent from compiling the test with old > binutils non supporting sve: maybe you also need to add > aarch64_asm_sve_ok as in the other testcase? It should be OK. aarch64_sve_hw is supposed to imply aarch64_asm_sve_ok, since it needs to both assemble and run SVE code. Thanks, Richard 2018-03-14 Richard Sandiford <richard.sandif...@linaro.org> gcc/testsuite/ * gcc.target/aarch64/sve/mul_highpart_1_run.c: Restrict to aarch64_sve_hw. Index: gcc/testsuite/gcc.target/aarch64/sve/mul_highpart_1_run.c =================================================================== --- gcc/testsuite/gcc.target/aarch64/sve/mul_highpart_1_run.c 2018-03-13 15:11:55.402370138 +0000 +++ gcc/testsuite/gcc.target/aarch64/sve/mul_highpart_1_run.c 2018-03-14 09:06:36.946848641 +0000 @@ -1,4 +1,4 @@ -/* { dg-do run } */ +/* { dg-do run { target aarch64_sve_hw } } */ /* { dg-options "-O2 -ftree-vectorize -fno-vect-cost-model --save-temps" } */ #include "mul_highpart_1.c"