On Tue, Mar 6, 2018 at 2:28 AM, Jakub Jelinek <ja...@redhat.com> wrote:
> On Tue, Mar 06, 2018 at 03:13:11AM -0300, Alexandre Oliva wrote:
>> Jakub wrote (in the BZ):
>>
>> > I meant to say:
>> > The char * GTY ((tag ("dw_val_class_symview"))) val_symbolic_view; line
>> > should come at the and of the union, not before the other classes.
>>
>> I've moved the union field down in the revised patch below, but I don't
>> see the point, and I thought it would be better to keep it close to
>> logically-similar entries. If the point is just to make it parallel to
>> the order of the enum (which manh other entries don't seem to have cared
>> about), maybe moving the enum would be better?
>
> I think the order should match the order of the dw_val_class entries and
> should be sorted from the most commonly used ones (ones used by most
> different attributes etc.), so that somebody trying to learn dwarf2out
> stuff can learn it more easily (say the dw_val_class_const,
> dw_val_class_const_unsigned, dw_val_class_flag first etc.), but apparently
> it is completely random already, I'll defer to Jason what he wants.
I don't think the order of the GTY tags matters much, it's just boilerplate.
Jason
