OK.
On Sat, Mar 3, 2018 at 4:50 AM, Paolo Carlini <paolo.carl...@oracle.com> wrote: > Hi, > > On 03/03/2018 06:13, Jason Merrill wrote: >> >> On Fri, Mar 2, 2018 at 4:02 PM, Paolo Carlini <paolo.carl...@oracle.com> >> wrote: >>> >>> this error recovery ICE happens only with -Os and is just a P5 - on the >>> other hand I would argue the reproducer isn't that exotic! - but seems >>> fixable easily and safely: cdtor_comdat_group immediately calls >>> DECL_ASSEMBLER_NAME on both arguments and of course crashes if they are >>> null. Tested x86_64-linux. >> >> It would make more sense to me to do this check and return right after >> populate_clone_array. > > Oh nice. Then, given that the existing 'if (fns[0] && ...' looked a bit > weird to me, to be super safe I also ran the the testsuite with 'gcc_assert > (fns[0] && fns[1]);' and everything went well, it only triggered for the new > testcase. Is the below OK? > > Thanks, > Paolo. > > //////////////////////
