> The autotools library macro (AX_PTHREAD) is now used to detect if > pthreads is present and multi-threaded linking in gold is automatically > enabled if it is found. This enables multi-threaded gold on platforms > where pthreads is enabled via other methods than just -lpthread (e.g. > MinGW) > > Signed-off-by: Joshua Watt <jpewhac...@gmail.com> > --- > config/ax_pthread.m4 | 485 ++++++++++++++++++++++++++++ > gold/Makefile.am | 11 +- > gold/Makefile.in | 22 +- > gold/aclocal.m4 | 1 + > gold/configure | 767 > +++++++++++++++++++++++++++++++++++++++++++-- > gold/configure.ac | 23 +- > gold/testsuite/Makefile.in | 8 +- > 7 files changed, 1254 insertions(+), 63 deletions(-)
Thanks for the patch! I have a few preliminary questions and comments... First, do you or your company have a copyright assignment on file with FSF? I could be wrong, but I believe adding to config/ will require approval from a GCC config/ maintainer. The normal process, as I understand it, would be to add the file to the GCC tree, then sync it into the binutils tree. I'm not in a position to approve that, nor can I judge on the acceptability of the copyright notice in that file. I'd like to retain the ability to use --disable-threads as a configure option. If this is just to get MinGW on board, is there a lighter-weight way of doing that? Could we just add a configure option that switches between -lpthread and -pthread (or whatever option is needed)? I like the idea of fully automating it, but that's a pretty big m4 file! Anyway, I'd like to hear what the GCC folks think of adding ax_pthread.m4 to the config/ directory. (BTW, In the future, please omit diffs from generated files from your patch.) -cary
