On Wed, 2018-02-14 at 04:53 -0600, Segher Boessenkool wrote:
> Hi!
>
> On Tue, Feb 13, 2018 at 05:40:08PM -0600, Will Schmidt wrote:
> > Some of our builtin definitions were allowing invalid parameters, and a
> > subsequent ICE (on invalid code) were the result. This is due to the use of
> > RS6000_BTI_NOT_OPAQUE (which allowed vector arguments), where a
> > RS6000_BTI_INTSI appears to be a more appropriate choice.
> > This change adjusts the definitions for the VEC_SLD, VEC_SLDW, vec_XXSLDWI
> > and VEC_XXPERMDI entries.
>
> > --- /dev/null
> > +++ b/gcc/testsuite/gcc.target/powerpc/pr84220-xxperm.c
> > @@ -0,0 +1,100 @@
> > +/* PR target/84220 */
> > +/* Test to ensure we generate invalid parameter errors rather than an ICE
> > + when calling vec_xxpermdi() with invalid parameters. */
> > +/* { dg-do compile { target { powerpc64*-*-* } } } */
> > +/* { dg-require-effective-target powerpc_vsx_ok } */
> > +/* { dg-options "-O2 -mvsx" } */
>
> Does this test need powerpc64*? Or does it need lp64 instead, or nothing?
Good catch. :-) slightly more coverage when removing the target.
Changed it to just a dg-do compile stanza to match the other tests.
Thanks,
-Will
> Looks good, please look at that detail again; okay for trunk. Thanks!
>
>
> Segher
>
