> On Jan 19, 2018, at 7:53 PM, David Edelsohn <dje....@gmail.com> wrote: > > On Fri, Jan 19, 2018 at 3:58 PM, Bill Schmidt > <wschm...@linux.vnet.ibm.com> wrote: >> Hi, >> >> My recent patches to trunk and gcc-7-branch for avoiding speculation of >> indirect branches has a flaw, pointed out by David. Usage of "." to >> represent the program counter is not portable across all POWER >> assemblers, particularly not being accepted on AIX. "$" is the >> universally accepted alternative. So change the code and the test >> cases to use $ instead of . for this purpose. >> >> Regstrap is in progress on powerpc64-linux-gnu and powerpc64le-linux-gnu. >> Assuming no issues are found, is this okay for trunk and backport to 7? > > Once I got past the "." issue, I have discovered that the AIX > assembler also doesn't like > > crset eq > > It doesn't like the symbolic name for the operand, it wants a numeric > operand for "eq".
This seems to me to be a different matter. The ISA defines this syntax in Appendix C and specifies that assemblers should provide everything listed there. The use of eq standing alone is shown in the examples in section C.3. So the AIX assembler is noncompliant in this case. I realize that as a practical matter we have to deal with that, but this needs to be fixed at some point. Where do we file the bug report? I'm having a lot of heartburn over this because my test machine is experiencing disk slowdowns, so it's taking me up to 4 hours to complete a bootstrap and regression test. So whenever my current test finishes I plan to repost the patch in existing form so that it can be committed tomorrow. I'll try to set up another patch later tonight if I don't completely run out of gas so it can burn overnight. But frankly I may not manage it. Bill > > Thanks, David >
