Hi Kyrill,
On 17 January 2018 at 12:20, Kyrill Tkachov
<[email protected]> wrote:
> Hi all,
>
> This patch converts gcc.target/arm/pr40887.c to use the proper effective
> target check and dg-add-options for armv5te
> so that we avoid situations where we end up trying to compile the test with
> a Thumb1 hard-float ABI, which makes the
> compiler complain.
>
> This allows the test to pass gracefully for me for my compiler configured
> with:
> --with-cpu=cortex-a15 --with-fpu=neon-vfpv4 --with-float=hard
> --with-mode=thumb
>
> Committing to trunk.
>
> Thanks,
> Kyrill
>
> 2018-01-17 Kyrylo Tkachov <[email protected]>
>
> * gcc.target/arm/pr40887.c: Add armv5te effective target checks and
> directives.
I think you had to swap dg-options and dg-add-options directives, so I
committed the attached patch as obvious.
Christophe
2018-01-18 Christophe Lyon <[email protected]>
* gcc.target/arm/pr40887.c: Fix dg-options and dg-add-options
order.
Index: gcc/testsuite/gcc.target/arm/pr40887.c
===================================================================
--- gcc/testsuite/gcc.target/arm/pr40887.c (revision 256838)
+++ gcc/testsuite/gcc.target/arm/pr40887.c (revision 256839)
@@ -1,8 +1,8 @@
/* { dg-do compile } */
/* { dg-skip-if "need at least armv5" { *-*-* } { "-march=armv[234]*" } { "" }
} */
/* { dg-require-effective-target arm_arch_v5te_ok } */
+/* { dg-options "-O2" } */
/* { dg-add-options arm_arch_v5te } */
-/* { dg-options "-O2" } */
/* { dg-final { scan-assembler "blx" } } */
int (*indirect_func)(int x);
