Re: [PATCH v2] Fix failure building LLVM with location wrapper nodes (PR c++/83799)

[David Malcolm]

On Fri, 2018-01-12 at 12:37 -0500, David Malcolm wrote:
> On Fri, 2018-01-12 at 09:07 +0100, Markus Trippelsdorf wrote:
> > On 2018.01.11 at 18:21 -0500, David Malcolm wrote:

[...snip...]

> > Thanks for the fix. Minor nit:
> > Please make TargetLoweringBase and TargetLoweringBase a struct
> > instead
> > of a class, to prevent illegal access of private members.
> 
> Here's an updated version of the patch which does so (so that the
> testcase compiles cleanly on clang).
> 
> I also added some more assertions to
> selftest::test_type_dependent_expression_p.
> 
> Successfully bootstrapped&regrtested on x86_64-pc-linux-gnu.
> Manually tested with "make s-selftest-c++" (since we don't run the
> selftests for cc1plus by default).
> 
> OK for trunk?

Jason approved the v2 patch on IRC, so I've committed it to trunk as
r256796.

[...snip...]