Hi Jan, >> It makes the option using thunks unusable though, right? Can you simply make >> them hidden on systems without comdat support? That duplicates them per TU >> but at least the feature works. Or those systems should provide the >> thunks via >> libgcc. >> >> I agree we can followup with a fix for Solaris given lack of a public >> testing machine. > > My memory is bit dim, but I am convinced I was fixing specific errors for > comdats > on Solaris, so I think the toolchain supports them in some sort, just is more > restrictive/different from GNU implementation.
comdat does work just fine in Solaris 11, but the Solaris 10 linker has problems with what gcc generates. > Indeed, i think just producing sorry, unimplemented message is what we should > do > if we can't support retpoline on given target. Certainly, coupled with an appropriate effective-target keyword to limit testcases appropriately. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University