Hi Mike,
On Wed, Jan 10, 2018 at 04:53:57PM -0500, Michael Meissner wrote:
> This patch is next in my series of patches to enable us to configure the long
> double type on PowerPC systems. This patch is only about the configuration
> option. A future patch will contain the multilib support.
>
> This patch needs the previous patch I submitted today (January 10th, 2018)
> applied before it will work.
> https://gcc.gnu.org/ml/gcc-patches/2018-01/msg00806.html
>
> I built a bootstrap configuratrion on a little endian power8 system using the
> --with-long-double-format-ibm option and it passed with no regressions. I
> also
> built a non-bootstrap version using --with-long-double-format-ieee and I
> verified that it defaulted to IEEE 128-bit for long double. Can I check this
> patch into the trunk once the previous patch has been checked in?
>
> 2018-01-10 Michael Meissner <meiss...@linux.vnet.ibm.com>
>
> * configure.ac (--with-long-double-format): Add support for the
> configuration option to change the default long double format on
> PowerPC systems.
> * config.gcc (powerpc*-linux*-*): Likewise.
> * configure: Regenerate.
> * config/rs6000/rs6000-c.c (rs6000_cpu_cpp_builtins): If long
> double is IEEE, define __KC__ and __KF__ to allow floatn.h to be
> used without modification.
> +# Check if TFmode long double target should use the IBM extended double or
> IEEE
> +# 128-bit floating point formats if long doubles are 128-bits long. The long
> +# double type can only be switched on powerpc64 bit Linux systems where VSX
> is
> +# supported. Other PowerPC systems do not build the IEEE 128-bit emulator in
> +# liggcc.
Typo ("libgcc").
> +AC_ARG_WITH([long-double-format],
> + [AS_HELP_STRING([--with-long-double-format={ieee,ibm}]
> + [Specify whether PowerPC long double uses IEEE or IBM
> format])],[
> +case x"$target:$with_long_double_format" in
(This does not need the "x" thing because the string can never be empty:
there always is the ":", for starters).
> + xpowerpc64le-*-linux*:ieee | xpowerpc64le-*-linux*:ibm)
> + :
> + ;;
> + xpowerpc64-*-linux*:ieee | xpowerpc64-*-linux*:*:ibm)
I think you have an extra ":*" here.
> + # IEEE 128-bit emulationr is only built on 64-bit VSX Linux systems
Typo ("emulation").
The configure script looks more complicated than it has to (you can first
check for valid ieee|ibm and then do the rest, for example).
Okay for trunk with the typos fixed. Thanks,
Segher
