On Wed, Jan 03, 2018 at 05:21:27PM +0000, Michael Collison wrote: > Hi all, > > This patch adds two new command line options for the legacy cryptographic > extensions AES (+aes) and SHA-1/SHA-2 (+sha2). Backward compatibility is > retained by modifying the +crypto feature modifier to enable +aes and +sha2. > > Bootstrapped on aarch64-none-elf. Tested with new binutils and verified all > instructions assembly correctly.
I'm a bit confused by this testing statement. aarch64-none-elf is not a bootstrap target. Was this bootstrapped or only tested with a cross-compiler (or both)? Was the testsuite also run? I don't see any new instructions in this patch that would need a new binutils. The patch is OK, but please clarify how it has been tested. Thanks, James
