On Mon, Jan 08, 2018 at 01:02:37PM -0500, David Malcolm wrote: > Thanks Nathan and Jakub: a quick smoketest using TREE_LANG_FLAG_0 > worked, and fixes this issue. > > However, should I be using a TREE_LANG_FLAG for something that's in > tree.h/c, rather than just in the "cp" subdir? (the wrapper nodes are > only added to C++ in this patch kit, but given that e.g. STRIP_NOPS > needs to remove them, the lang-independent code needs to handle them, > and ultimately we may want wrapper nodes in other FEs).
If location_wrapper_p etc. are in generic code rather than only in the FE, sure, you'd need to use some generic flag rather than FE specific. I bet e.g. private_flag and protected_flag aren't used yet for VIEW_CONVERT_EXPR/NON_LVALUE_EXPR, but they are used on some other expressions, e.g. CALL_EXPR, which suggests that it could be used for that. Jakub