Hi all, as long as the computation where the token can be found is adapted in the same way, i.e. the token's offset in the derived type monitors the changed position, everything is fine. When I remember correctly, then this is done automatically by the routines setting up the caf_ref-chain for referencing into coarrays of derived type's (trans-intrinsic.c:~1239 for example). So if everything works, ok for trunk and gcc-7.
Regards, Andre On Thu, 28 Dec 2017 11:37:00 +0000 Paul Richard Thomas <paul.richard.tho...@gmail.com> wrote: > Hi All, > > OK - I'll hold back until I hear from Damian & Zaak. > > Cheers > > Paul > > On 27 December 2017 at 21:06, Damian Rouson > <dam...@sourceryinstitute.org> wrote: > > > > Thanks for the additional information Thomas. It sounds like I should test > > Paul’s patch. I should be able to do so today and will post the results by > > tomorrow. I’m adding OpenCoarrays developer Zaak Beekman to the cc and > > attaching the patch again in case he wants to try it as well. > > > > Zaak, the full thread is at https://gcc.gnu.org/ml/fortran/ and starts with > > a message from Paul on November 29. > > > > Damian > > > > On December 27, 2017 at 11:09:29 AM, Thomas Koenig > > (tkoe...@netcologne.de(mailto:tkoe...@netcologne.de)) wrote: > >> Hi Damian, > >> > >> > Does breaking binary compatibility simply mean that CAF codes will need > >> > to be recompiled (which is fine) > >> > >> Well... not really. We are not supposed to break binary compatibility > >> in a release. For gcc-8, we have greater freedom because we had to > >> do it anyway. > >> > >> Now, the interesting question is the impact. If we break binary > >> compatibilty for something that never worked anyway or was useless, or > >> something that was broken by a gcc-7 regression, I think we're fine. > >> > >> If not, well... one possible decision would be to wait for gcc-8 to > >> fix this. > >> > >> > or does it mean that there will need to be work done on OpenCoarrays > >> to support the changes > >> > >> This, I don't know, never having looked at the OpenCoarrays source. > >> > >> Regards > >> > >> Thomas > > > -- Andre Vehreschild * Email: vehre ad gmx dot de