On Dec 21, 2017, Jeff Law <l...@redhat.com> wrote: > FWIW I wouldn't be surprised if there's other places in reorg that are > going to need similar fixes.
*nod*. I looked around, and the only place that seemed suspicious was find_end_label, but I'm not sure we might actually use a debug insn as the insertion point there. I could conservatively tweak it to avoid the possibility, but I'm usually more comfortable when I have a testcase that shows the problem for sure. The other places that emit insns seem to be (re)emitting actual insns, or emitting copies thereof, and in these cases their preexisting locations are retained/copied. That's unlike the just-fixed fragment, that took just a pattern and emitted it as a new insn before or after another: this copied the INSN_LOCATION from the other insn, which is undesirable. -- Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin America board member Free Software Evangelist|Red Hat Brasil GNU Toolchain Engineer
