On Tue, Dec 19, 2017 at 9:29 AM, Uros Bizjak <ubiz...@gmail.com> wrote: > On Mon, Dec 18, 2017 at 2:42 PM, Koval, Julia <julia.ko...@intel.com> wrote: >> Hi, I tried to replace 2 flags variable with c++ bitset(in patch attached). >> What do you think? > > Hm, I'm not a c++ person, but I wonder about overhead and performance > impact of this change. Maybe [] operator could be used instead of a > dynamic handling here. Please discuss with a c++ person to find out > the most appropriate approach.
The natural GCC data structure is a sbitmap ... I'd rather not use <bitset> given we have a GCC variant. >>> Please add these options first. >> 2 options left(they are under Kirill's review currently), I'll add PTAs for >> them to the patch, as soon as they will be commited. > > Actually, let's wait for these 2 options to be reviewed and committed > first, and after that introduce -march=icelake handling. > > Uros.
