On Tue, Nov 14, 2017 at 01:57:21PM +0100, Rainer Orth wrote:
> > And the preexisting:
> > case "$host" in
> > *-*-darwin*) MAC_INTERPOSE=true ; enable_static=no ;;
> > *) MAC_INTERPOSE=false ;;
> > esac
> > AM_CONDITIONAL(USING_MAC_INTERPOSE, $MAC_INTERPOSE)
> > looks wrong too.
>
> Wrong in which way? Just the location?
>
> >> --- a/libsanitizer/lsan/lsan_common.h
> >> +++ b/libsanitizer/lsan/lsan_common.h
> >> @@ -20,6 +20,7 @@
> >> #include "sanitizer_common/sanitizer_stoptheworld.h"
> >> #include "sanitizer_common/sanitizer_symbolizer.h"
> >>
> >> +#ifndef CAN_SANITIZE_LEAKS
> >
> > Obviously better would be to move the Darwin version checks here, but if
> > upstream refuses to do that, we can do it this way too.
>
> Kostya suggested the same. I see now that
> sanitizer_common/sanitizer_platform_interceptors.h already uses
> __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__, so I'll give it a try.
Any progress with this?
Jakub
