On Fri, Dec 15, 2017 at 02:01:36PM -0500, Jason Merrill wrote:
> On 11/29/2017 08:19 PM, Martin Sebor wrote:
> > On 11/29/2017 03:32 PM, Jakub Jelinek wrote:
> > > + if (!tree_fits_uhwi_p (tsize))
> > > + {
> > > + error_at (loc, "%u names provided while %qT decomposes into "
> >
> > When count is 1 as in the test below the error isn't grammatically
> > correct ("1 names"). I see that the same message is already issued
> > elsewhere in the function so this seems like an opportunity to use
> > the right form here and also fix the other one at the same time or
> > in a followup. The error_n function exists to issue the right form
> > for the language, singular or plural. It's not as convenient when
> > the sentence contains two terms that may be singular or plural,
> > but that can also be dealt with.
>
> Agreed.
Yeah, I've implemented it as an incremental patch.
So
http://gcc.gnu.org/ml/gcc-patches/2017-11/msg02521.html
for the ICE and
http://gcc.gnu.org/ml/gcc-patches/2017-11/msg02538.html
on top of it. The latter is what Nathan approved already, the former
needs review.
Jakub
