Jakub Jelinek <ja...@redhat.com> writes:

> On Fri, Dec 08, 2017 at 10:43:58AM +0100, Rainer Orth wrote:
>> The line numbers are completely misleading, unfortunately.  Hadn't
>> SUBTARGET_ATTRIBUTE_TABLE been used at the end of the (very short)
>> sparc_attribute_table, I wouldn't have seen what was wrong.
>> 
>> The following patch fixes the problem, installed on mainline after
>> i386-pc-solaris2.11 and sparc-sun-solaris2.11 bootstraps completed
>> without regressions.
>> 
>> However, there are two more SUBTARGET_ATTRIBUTE_TABLE defines:
>> 
>> gcc/config/darwin.h:#define SUBTARGET_ATTRIBUTE_TABLE \
>> gcc/config/i386/cygming.h:#define SUBTARGET_ATTRIBUTE_TABLE \
>
> I'll deal with this.

This is what I'm currently testing with an  x86_64-apple-darwin11.4.2
bootstrap.  Ok if it passes?

Thanks.

        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


2017-12-08  Rainer Orth  <r...@cebitec.uni-bielefeld.de>

        * config/darwin.h (SUBTARGET_ATTRIBUTE_TABLE): Initialize new
        member of struct attribute_spec.

diff --git a/gcc/config/darwin.h b/gcc/config/darwin.h
--- a/gcc/config/darwin.h
+++ b/gcc/config/darwin.h
@@ -742,11 +742,11 @@ extern GTY(()) section * darwin_sections
 /* Extra attributes for Darwin.  */
 #define SUBTARGET_ATTRIBUTE_TABLE					     \
   /* { name, min_len, max_len, decl_req, type_req, fn_type_req, handler,     \
-       affects_type_identity } */						     \
+       affects_type_identity, exclude } */				     \
   { "apple_kext_compatibility", 0, 0, false, true, false,		     \
-    darwin_handle_kext_attribute, false },				     \
+    darwin_handle_kext_attribute, false, NULL },			     \
   { "weak_import", 0, 0, true, false, false,				     \
-    darwin_handle_weak_import_attribute, false }
+    darwin_handle_weak_import_attribute, false, NULL }
 
 /* Make local constant labels linker-visible, so that if one follows a
    weak_global constant, ld64 will be able to separate the atoms.  */

Reply via email to