On Mon, Dec 04, 2017 at 05:33:37PM +0000, Steve Ellcey wrote: > On Mon, 2017-12-04 at 17:18 +0000, Kyrill Tkachov wrote: > > > > +(define_insn_reservation "thunderx2t99_multiple" 1 > > > + (and (eq_attr "tune" "thunderx2t99") > > > + (eq_attr "type" "multiple")) > > > + "thunderx2t99_i0+thunderx2t99_i1+thunderx2t99_i2+thunderx2t99_ls > > > 0+thunderx2t99_ls1+thunderx2t99_sd+thunderx2t99_i1m1+thunderx2t99_i > > > 1m2+thunderx2t99_i1m3+thunderx2t99_ls0d1+thunderx2t99_ls0d2+thunder > > > x2t99_ls0d3+thunderx2t99_ls1d1+thunderx2t99_ls1d2+thunderx2t99_ls1d > > > 3+thunderx2t99_f0+thunderx2t99_f1") > > > + > > We try to adhere to the 80 columns per line rule in the scheduling > > description files as well, > > so can you please use "\" to break this into multiple lines. > > Yes, I wasn't sure if whatever program parses this file would honor > backslashes so I didn't break it up. The falkor_extra definition in > falkor.md that I looked at is more than 80 characters and that is one > of the reasons I wasn't sure backslashes would be honored. But I see > other places (power8.md) where the backslashes are used so I will make > that change if and when the patch is approved.
As long as it bootstraps I'm happy to take it - I'm sure you're better placed to spot and understand regressions in thunderx2t99 performance than I am. OK Thanks, James
