On 11/27/2017 03:16 PM, David Malcolm wrote: > On Mon, 2017-11-27 at 09:40 +0100, Olivier Hainque wrote: >> (typo in David's email address in the previous message, >> resending. sorry for the duplicates) >> >> Hi Jeff, >> >> (Thanks for your feedback) >> >>> On Nov 27, 2017, at 04:55 , Jeff Law <l...@redhat.com> wrote: >>> >>>> * Makefile.in (SELFTEST_FLAGS): Use nul instead of /dev/null >>>> on mingw build hosts. >>> >>> Would it make more sense to set the output file to HOST_BIT_BUCKET >>> when >>> -fselftest is active? >> >> >> Hmm, possibly. Interesting suggestion :) >> >> David, who introduced the framework, would >> know for sure - cc'ed. >> >> David, thoughts on this ? > > [CCing Tamar] > > The selftests currently assume both: > (a) reading a source file from /dev/null, and > (b) writing the generated asm to /dev/null > > I note that r241895 added "-o /dev/null" for the asm output to "Fix the > Windows native x86-64 build.": > > +2016-11-07 Tamar Christina <tamar.christ...@arm.com> > + > + PR driver/78196 > + * Makefile.in (SELFTEST_FLAGS): Added -o /dev/null. > + > > HOST_BIT_BUCKET seems to be a header thing, rather than a Makefile > thing; presumably there would need to be logic to handle both input and > output for the HOST_BIT_BUCKET approach. Well, the idea was that HOST_BIT_BUCKET is available inside the compiler itself. So rather than hacking it into the Makefile as well, we'd just force the compiler driver to DTRT, utilizing the existing xm.h define along the way.
> > Given that, I prefer Olivier's patch - it seems simpler to me. OK. I can live with it. jeff
