On 11/23/2017 02:45 AM, Koval, Julia wrote: > Sorry, I think in this version of this patch they are fixed. > >> -----Original Message----- >> From: Joseph Myers [mailto:jos...@codesourcery.com] >> Sent: Wednesday, November 22, 2017 6:23 PM >> To: Koval, Julia <julia.ko...@intel.com> >> Cc: Jeff Law <l...@redhat.com>; Jakub Jelinek <ja...@redhat.com>; GCC >> Patches <gcc-patches@gcc.gnu.org> >> Subject: RE: [patch] remove cilk-plus >> >> This patch version does not appear to address my comment that you're >> leaving behind comments in c-parser.c relating to Cilk array notations >> while removing the subsequent code. (Or in one case actually reindenting >> the comment that is no longer relevant, rather than removing it.) >> >> -- >> Joseph S. Myers >> jos...@codesourcery.com This version is fine to commit.
Can you also remove struct inv_list from c-family/c-common.h. It was only used for array notation support. You can include that in your main commit or as a separate follow-up. We may well find other nits like inv_list. I'm comfortable addressing those as we bump into them. Thanks for taking care of this! jeff
