On Sat, Nov 25, 2017 at 11:21:49AM +0100, Eric Botcazou wrote:
> 
> this is the (hopefully) final implementation of the support for the unrolling 
> pragma in the Fortran front-end.  However the documentation is still missing 
> because I don't really know where and under which form to put it.
> 
> Tested on x86_64-suse-linux, OK for the mainline?
> 

Eric, 

The patch looks ok to me.  For documentation, the gfortran
manual has 2 sections:

6.1 Extensions implemented in GNU Fortran
7.2 GNU Fortran Compiler Directives

6.1 describes extension covering legacy code and vendor extensions.
7.2 describes other !$GCC directives.  Currently, the section is
mainly calling conventions (CDECL, STDCALL, etc) and library 
macroc (DLLEXPORT).  These should probably be in 7.2.1 and the 
UNROLL directive in 7.2.2.

I can help with the documentation (although it might take a weekend
or two to get done), but need to know sematics.  Does the directive
apply to only the immediately following loop?  Does it apply to all
loops that follow the directive?  What is the interaction of the
directive with -funroll-loops and --param max-unroll-times=4?

-- 
Steve

Reply via email to